Skip to content

update PelePhysics#545

Merged
baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom
baperry2:update-pelephys
Jul 31, 2025
Merged

update PelePhysics#545
baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom
baperry2:update-pelephys

Conversation

@baperry2
Copy link
Copy Markdown
Collaborator

Expect some minor diffs in unit tests due to AMReX-Combustion/PelePhysics#595 but maybe it's causing some tests to fail?

@baperry2
Copy link
Copy Markdown
Collaborator Author

@ThomasHowarth and @JustinFreiberger: any idea why the performance optimizations for diffusion would be causing these failures in the PeleLMeX tests?

@ThomasHowarth
Copy link
Copy Markdown
Contributor

The UnitTest failure doesn't look too concerning (relative error differences on the order of 10^-16). The others are weird, and I can't reproduce them on my local machine. I've had similar things happen when doing something else with the EBBFS test, where it had an MLMG failure that I couldn't reproduce locally. Have you managed to reproduce any of these errors?

@d-montgomery
Copy link
Copy Markdown
Contributor

I was able to reproduce the Spray test error locally, but not the MLMG errors from EBBFS.

@ThomasHowarth
Copy link
Copy Markdown
Contributor

Looks like a slight deviation in the multigrid solve caused the EBBFS test (which may also fix my other ongoing PR), and the missing initialisation (sorry about that) caused the spray issue. Do we reckon there are any other issues?

@baperry2
Copy link
Copy Markdown
Collaborator Author

I slightly loosened the tolerances for the failing linear solve. The EBBFS case initialization has a discontinuity near an EB corner so it makes sense that it would be especially sensitive. In any event it seems to run ok after getting past the failing linear solve on the 1st timestep.

I don't think there are any more issues.

@baperry2 baperry2 requested a review from ThomasHowarth July 31, 2025 17:22
@baperry2 baperry2 merged commit 2357d3b into AMReX-Combustion:development Jul 31, 2025
23 of 24 checks passed
@baperry2 baperry2 deleted the update-pelephys branch July 31, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants