update PelePhysics#545
Conversation
|
@ThomasHowarth and @JustinFreiberger: any idea why the performance optimizations for diffusion would be causing these failures in the PeleLMeX tests? |
|
The UnitTest failure doesn't look too concerning (relative error differences on the order of 10^-16). The others are weird, and I can't reproduce them on my local machine. I've had similar things happen when doing something else with the EBBFS test, where it had an MLMG failure that I couldn't reproduce locally. Have you managed to reproduce any of these errors? |
|
I was able to reproduce the Spray test error locally, but not the MLMG errors from EBBFS. |
|
Looks like a slight deviation in the multigrid solve caused the EBBFS test (which may also fix my other ongoing PR), and the missing initialisation (sorry about that) caused the spray issue. Do we reckon there are any other issues? |
|
I slightly loosened the tolerances for the failing linear solve. The EBBFS case initialization has a discontinuity near an EB corner so it makes sense that it would be especially sensitive. In any event it seems to run ok after getting past the failing linear solve on the 1st timestep. I don't think there are any more issues. |
2357d3b
into
AMReX-Combustion:development
Expect some minor diffs in unit tests due to AMReX-Combustion/PelePhysics#595 but maybe it's causing some tests to fail?