Skip to content

EB-Inflow#515

Merged
baperry2 merged 18 commits intoAMReX-Combustion:developmentfrom
baperry2:ebinflow-rebase-psf
May 22, 2025
Merged

EB-Inflow#515
baperry2 merged 18 commits intoAMReX-Combustion:developmentfrom
baperry2:ebinflow-rebase-psf

Conversation

@baperry2
Copy link
Copy Markdown
Collaborator

@baperry2 baperry2 commented May 18, 2025

Import EB-Inflow capability from @esclapez for new changes based on #477 (v1.0.0)

TODO:

  • Port test case with an EB-inflow to PeleLMeX v1.0.0 prob file formatting
  • Doc updates

@escalpez - let me know if you've already done this in a branch somewhere!

esclapez and others added 4 commits May 16, 2025 16:46
…still missing.

Update EB_BackwardStepFlame regtest.

Add a partially-premixed backward-facing case for EB inflow.

Prepare ground for wall laws: pass normal and cell-centroid state in EBfill function.

fix bug introduced when rebasing
@baperry2
Copy link
Copy Markdown
Collaborator Author

Closes #473

@baperry2 baperry2 linked an issue May 18, 2025 that may be closed by this pull request
@baperry2 baperry2 force-pushed the ebinflow-rebase-psf branch from 9d08f82 to 9821293 Compare May 19, 2025 20:06
@baperry2 baperry2 force-pushed the ebinflow-rebase-psf branch from 9821293 to e914b19 Compare May 19, 2025 21:41
@baperry2 baperry2 marked this pull request as ready for review May 19, 2025 22:20
@baperry2 baperry2 force-pushed the ebinflow-rebase-psf branch from 4348e69 to bba1de9 Compare May 19, 2025 22:22
@baperry2 baperry2 requested review from esclapez and jrood-nrel May 19, 2025 22:22
@baperry2 baperry2 force-pushed the ebinflow-rebase-psf branch from bba1de9 to c5f5468 Compare May 19, 2025 23:16
@esclapez
Copy link
Copy Markdown
Collaborator

@baperry2 Sorry, I did have that somewhere but I've got a bit too much on my plate lately.
We can move forward with the PR to have this feature available in dev, but a couple of things to keep in mind:

  • currently no scalar diffusion on eb-inflow
  • I'm not sure the SFINAE code in EB_BCfill.H is still useful with the PSF struct.
  • keeping separate EB_inflow and EB_isoT is pretty limited. I was thinking of having a params EB2.bc_type that defaults to wall_no_slip_adiab, but can be changed to wall_no_slip_isoT (+ parsing a single value for T) or wall_slip_adiab if/when we have wall models. Or EB2.bc_type = UserDefined which trigger the use of the bcnormal_eb, bctype_eb.

Maybe those things can be adressed down the line (hopefully not too far), but I would add warning on that capability in the doc for now saying that it's still under development.

@baperry2
Copy link
Copy Markdown
Collaborator Author

Thanks for the comments @esclapez. We do need this capability in dev for a current project, so I'll probably merge with the code as is and we can add more refinement later.

  • Scalar diffusion on EB-inflow would be good to have, but most of the time advection probably dominates immediately at the inflow face so I'm fine with having it as is for the moment.
  • The SFINAE stuff isn't strictly necessary but it does fail a bit more gracefully so I left it in.
  • I will add some warnings in the docs and perhaps in the code that this capability is still in development and may change.

@baperry2 baperry2 force-pushed the ebinflow-rebase-psf branch from bec05a9 to 8a89163 Compare May 22, 2025 16:58
@baperry2 baperry2 enabled auto-merge (squash) May 22, 2025 16:58
@baperry2 baperry2 merged commit b388ef7 into AMReX-Combustion:development May 22, 2025
24 checks passed
@baperry2 baperry2 deleted the ebinflow-rebase-psf branch May 22, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable inflow on EBs

3 participants