Merged
Conversation
…still missing. Update EB_BackwardStepFlame regtest. Add a partially-premixed backward-facing case for EB inflow. Prepare ground for wall laws: pass normal and cell-centroid state in EBfill function. fix bug introduced when rebasing
Collaborator
Author
|
Closes #473 |
Closed
9d08f82 to
9821293
Compare
9821293 to
e914b19
Compare
4348e69 to
bba1de9
Compare
bba1de9 to
c5f5468
Compare
jrood-nrel
approved these changes
May 21, 2025
Collaborator
|
@baperry2 Sorry, I did have that somewhere but I've got a bit too much on my plate lately.
Maybe those things can be adressed down the line (hopefully not too far), but I would add warning on that capability in the doc for now saying that it's still under development. |
Collaborator
Author
|
Thanks for the comments @esclapez. We do need this capability in dev for a current project, so I'll probably merge with the code as is and we can add more refinement later.
|
bec05a9 to
8a89163
Compare
esclapez
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import EB-Inflow capability from @esclapez for new changes based on #477 (v1.0.0)
TODO:
@escalpez - let me know if you've already done this in a branch somewhere!