use runtime specnames for manifold EOS, also add more physics checks#436
Merged
baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom Dec 10, 2024
Merged
Conversation
baperry2
force-pushed
the
manifold-spec-names
branch
from
8de6707 to
99b279d
Compare
update pp
baperry2
force-pushed
the
manifold-spec-names
branch
from
99b279d to
309159a
Compare
marchdf
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update PelePhysics to get AMReX-Combustion/PelePhysics#542
For manifold EOS, use runtime names for "species"/manifold parameters specified through eosparm. Allow mixture fraction and progress variable to be defined and derived, taking the appropriate manifold parameter.
Add more checks to ensure Manifold EOS isn't used with currently unsupported (or unnecessary) physics: Efield, Spray, Soot, Radiation, Closed Chamber, and wbar diffusion.