Skip to content

Parse for adv_redist_type and diff_redist_type#417

Merged
baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom
d-montgomery:development
Sep 23, 2024
Merged

Parse for adv_redist_type and diff_redist_type#417
baperry2 merged 1 commit intoAMReX-Combustion:developmentfrom
d-montgomery:development

Conversation

@d-montgomery
Copy link
Copy Markdown
Contributor

Added the ability to change the redistribution type for advection and diffusion by parsing input files.

Copy link
Copy Markdown
Collaborator

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@baperry2 baperry2 enabled auto-merge (squash) September 23, 2024 16:16
@baperry2 baperry2 merged commit 57bade8 into AMReX-Combustion:development Sep 23, 2024
@baperry2
Copy link
Copy Markdown
Collaborator

For posterity sake to remember the purpose of this: with isothermal EB, or potentially other EB cases, the chi_correction in the SDC iterations was not converging. This was because the redistribution process is arbitrary and does not enforce that RhoRT is maintained in the redistribution. We do a lot of work to ensure that the MAC velocity field divergence will result in constant RhoRT, then throw that away by applying redistribution to scalar advection. @dmontgomeryNREL found that turning off advection redistribution resolved our problems and did not lead to instability.

@d-montgomery
Copy link
Copy Markdown
Contributor Author

Case setup:
Rectangular domain with isothermal cylinder EB initialized with pure N2 at 143 K. The inlet CO2 mass fraction and temperature slowly increase from $Y_{CO2} = 0 \rightarrow 1$ and $T = 143 \rightarrow 293$ K, while the inlet N2 mass fraction decreases from $Y_{N2} = 1 \rightarrow 0$.

test_2Spec_EB_3SDC_DivuFirstIter_StateRedist_Surf

These plots demonstrate the effect of turning off flux redistribution for advection. The first plot is from a divergent simulation that resulted in NaN's with advective fluxes treated with state redistribution. The second is from a simulation where the redistribution is turned off for the advective fluxes.

test_2Spec_EB_3SDC_DivuFirstIter_StateRedist

test_2Spec_EB_3SDC_DivuFirstIter_NoRedist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants