Eosparm support in PeleLMeX#414
Merged
baperry2 merged 7 commits intoAMReX-Combustion:developmentfrom Sep 23, 2024
Merged
Conversation
9016162 to
db4d0c0
Compare
c30bcdb to
a50c552
Compare
marchdf
approved these changes
Sep 19, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress toward merging the manifold modeling stuff into PeleLMeX
Pass eosparm as argument into all EOS functions. Right now this is not necessary because it is only used by Manifold EOS, but this paves the way for that and should not negatively impact anything.