Spark ignition utility#404
Merged
baperry2 merged 10 commits intoAMReX-Combustion:developmentfrom Sep 6, 2024
Merged
Conversation
baperry2
reviewed
Sep 5, 2024
baperry2
requested changes
Sep 5, 2024
Collaborator
baperry2
left a comment
baperry2
left a comment
There was a problem hiding this comment.
Mostly looks good other than the few comments I added.
baperry2
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to add a source term to the energy equation, termed "spark". The energy is deposited in a discrete spherical region at a particular time, for a specified duration - some discussion could be had about making these continuous functions, rather than being clipped in this way. Multiple sparks can be defined, and inputs have been added to documentation. Addresses some discussions had here.