With AMReX PRs #4039 and #4048, face_divfree_interp ensures the#403
Merged
baperry2 merged 4 commits intoAMReX-Combustion:developmentfrom Aug 12, 2024
Merged
Conversation
cgilet
force-pushed
the
umac_ghostcell_update
branch
2 times, most recently
from
6cb068c to
8ef502b
Compare
marchdf
approved these changes
Aug 5, 2024
marchdf
requested changes
Aug 5, 2024
Contributor
marchdf
left a comment
marchdf
left a comment
There was a problem hiding this comment.
Can you update amrex submodule with this?
Contributor
|
Actually nvm, need to do a couple things first to get to that point |
divergence contraint in the ghost cells and no further correction is needed.
marchdf
force-pushed
the
umac_ghostcell_update
branch
from
087f3e7 to
62d060a
Compare
marchdf
approved these changes
Aug 5, 2024
Contributor
|
Going to wait on AMReX-Combustion/PelePhysics#519 to fix warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
divergence contraint in the ghost cells and no further correction is needed.