Reset time and nsteps#402
Merged
baperry2 merged 8 commits intoAMReX-Combustion:developmentfrom Aug 5, 2024
Merged
Conversation
baperry2
reviewed
Jul 26, 2024
Docs/sphinx/manual/LMeXControls.rst
Outdated
| peleLM.deltaT_tol = 1e-10 # [OPT, DEF=1.e-10] Tolerance of the deltaT solve | ||
| peleLM.evaluate_vars =... # [OPT, DEF=""] In evaluate mode, list unitTest: diffTerm, divU, instRR, transportCC | ||
| peleLM.do_patch_flow_variables = false # [OPT, DEF=false] Enable user-defined flow variable patching after reading a plot solution file | ||
| peleLM.do_reset_time = 1 # [OPT, DEF=1] Resets time and nsteps to 0 after restarting from a plot file. (Warning: plot file will be rewritten if not renamed and argument value = 0) |
Collaborator
There was a problem hiding this comment.
How about calling this peleLM.initDataPlt_reset_time so that it's obvious this setting only applies when initializing from a plt file? And a similar change for peleLM.do_path_flow_variables. Also, let's move these control entries to immediately below amr.initDataPlt in the documentation to make the association even more clear.
baperry2
approved these changes
Jul 26, 2024
Collaborator
baperry2
left a comment
baperry2
left a comment
There was a problem hiding this comment.
Looks good other than the minor change requested, so just go ahead and merge after making that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capability to reset (or not) time and nsteps after restarting from a plot file