Boundary patch implementation#369
Merged
baperry2 merged 20 commits intoAMReX-Combustion:developmentfrom May 7, 2024
Merged
Conversation
…hrough user-defined patches based on simple geometric shapes
jrood-nrel
requested review from
baperry2
and removed request for
esclapez and
jrood-nrel
Collaborator
|
A few general comments (I may have more when I dig in in more detail)
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ParallelAllReduce::Sum<Real>( | ||
| {sum_species_flux_global}, ParallelContext::CommunicatorSub()); | ||
| bpdevice->speciesFlux[m] = a_factor * sum_species_flux_global; | ||
| // amrex::Print()<<"\nNew func = "<<a_factor * sum_species_flux_global; |
Check notice
Code scanning / CodeQL
Commented-out code
| { | ||
| bool inside = false; | ||
|
|
||
| // auto dx = geom.CellSizeArray(); |
Check notice
Code scanning / CodeQL
Commented-out code
baperry2
requested changes
Apr 27, 2024
Collaborator
There was a problem hiding this comment.
Changes requested:
- Add documentation on additional input options
- In documentation, mention that bpatch fluxes are computed based on cell center locations on the coarsest level, so could differ from actual values when there is refinement
- Merge in fixes for host/device pointer stuff: SreejithNREL#1
baperry2
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionalities for reporting species mass flux through user-specified patches on non-EB boundaries. Patches are user specific zones that the user can specify-currently, patch types are full-boundary, circle, rectangle, circle-annular and rectangle-annular. Once the variable do_patch_mfr is set to 1, the solver writes down these fluxes similar to other temporals.