Incompressible fix/periodic channel/transport model consolidation#350
Merged
baperry2 merged 8 commits intoAMReX-Combustion:developmentfrom Mar 6, 2024
Merged
Conversation
This was
linked to
issues
Mar 1, 2024
Closed
baperry2
requested changes
Mar 1, 2024
Collaborator
There was a problem hiding this comment.
Thanks for this @ThomasHowarth!
The code looks good! Just a few changes:
- Handle the clang-tidy errors. We're a bit inconsistent about flags and have a mix of bools and ints. Bools in conditionals should just be like
if (boolvar), but ints should be likeif (intvar != 0). Sorry this is a bit annoying given the mix of different types. - Modify the documentation to account for the changes for constant Le diffusion. I think the only place this comes up is in the list of input file controls:
PeleLMeX/Docs/sphinx/manual/LMeXControls.rst
Line 252 in d30116e
- Also add the inputs for the periodic channel pressure gradient stuff to the controls section of the documentation
- There's one test case that uses unity_Le and the input file should be updated to account for your changes.
Contributor
Author
|
I have made all the specified changes. It is perhaps a little convoluted when it comes to the various models possible. Currently, if we run without LES you can fixed Le or Pr. It doesn't need to be both, but both would obviously lead to fixed Sc. With LES, we automatically run with fixed Pr/Sc (and hence fixed Le). Pr and Sc are specified in this case. Hopefully that makes sense, or happy to take suggestions. |
Closed
baperry2
approved these changes
Mar 6, 2024
Collaborator
baperry2
left a comment
baperry2
left a comment
There was a problem hiding this comment.
Looks good, thanks again @ThomasHowarth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following: