Fix no EB production cases#314
Merged
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom Nov 17, 2023
Merged
Conversation
Contributor
|
I would love to remove the EB ifdef and use all_regular like we do in PeleC sometime. |
jrood-nrel
approved these changes
Nov 17, 2023
Collaborator
|
It won't work as well for LMeX (removing the EB ifdef). The linear solvers are completely different for EB, with different algorithms even when all_regular (especially the nodal solver). The plain linear solvers are faster than the EB versions and the EB versions are not fully available with kernel-fusing ParFor, so they tend to scale not as good. Probably nothing you couldn't fix with time though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't compile with EB for Production cases that don't need it. Alternatively, we could still compile with EB but set
eb2.geom_type = all_regularin the input files.Closes #311