Adding the radiation module#313
Merged
baperry2 merged 18 commits intoAMReX-Combustion:developmentfrom Dec 7, 2023
Merged
Conversation
baperry2
reviewed
Nov 20, 2023
baperry2
reviewed
Nov 20, 2023
baperry2
reviewed
Nov 20, 2023
Member
Author
|
There is a data file required in the test case: Please let me know where you want it to be. |
Collaborator
|
That file isn't too big and we have similar pmf .dat files for the FlameSheet case. It can just go in the RegtTests/SootRadTest directory. |
Add SootRad case to CI testing
baperry2
approved these changes
Nov 28, 2023
marchdf
requested changes
Nov 29, 2023
marchdf
changed the title
21 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create the PR so that we can discuss it when we meet.
The build script:
https://github.com/AMReX-Combustion/PeleRad/blob/main/scripts/build_PeleLMeX_Frontier.sh