use regex to ignore headers from submodules for clang-tidy#308
use regex to ignore headers from submodules for clang-tidy#308baperry2 merged 6 commits intoAMReX-Combustion:developmentfrom
Conversation
|
I hate to ask but... are you confident this works? I was using this at some point: |
|
I did test, but not for Exec. I added that to the regex, as well as dummy code that should introduce warnings with Source, Exec, and PelePhysics to verify that these get caught. Presuming the clang-tidy tests here fail with the correct 3 warnings, I think this is ready to go (after removing the dummy code) |
|
nicely done! We need this for PeleC as well. Can you remove the grep now from the CI file? Also, does this make things faster? |
|
There isn't a significant impact on runtime, the main advantage is just getting 200MB of junk out of the log files The grep is still needed because a handful of warnings still come through from AMReX
|
3 participants
Right now we get a ton of clang-tidy warnings from sundials and amrex and just use grep to filter them out, but sometimes things get garbled and that fails.