Merged
Conversation
Co-authored-by: Bruce Perry <[email protected]>
baperry2
approved these changes
Oct 30, 2023
Makes some minor fixes to references cited in the JOSS paper (capitalization, missing details)
baperry2
approved these changes
Oct 31, 2023
Collaborator
baperry2
left a comment
baperry2
left a comment
There was a problem hiding this comment.
Can we fix Marc HdF's name so his first and last names are split properly in the citation files, and curly bracket {Henry de Frahan} in the bibtex?
Apparently with the CITATION.cff file, github will automatically generate a citation option that generates bibtex in the right side menu, so we don't strictly need that in the README, but it doesn't hurt.
Collaborator
Author
|
Indeed, it does add a APA/BibTex ref. link on the right, but this will make it more obvious :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of wrapping up the JOSS revisions, let's bring this into the main branch before creating a new release.