Skip to content

fixes for Efield after renaming LM to LMeX#283

Merged
baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom
baperry2:efield-fixes
Oct 16, 2023
Merged

fixes for Efield after renaming LM to LMeX#283
baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom
baperry2:efield-fixes

Conversation

@baperry2
Copy link
Copy Markdown
Collaborator

@baperry2 baperry2 commented Oct 13, 2023 •
edited
Loading

In #257 when file names were changed from LM to LMeX some of the Efield related file name changes were missed, due to lack of test coverage for Efield capability. This PR gets the Efield cases working, other than PremBunsen3DKuhl, which relies on a mechanism that doesn't exist in PelePhysics.

TODO:

  • Prior to the name change from LM to LMeX, a convention was mostly followed that files relating to the PeleLM class started with PeleLM, but files for other classes did not. Should we revert to that convention?
  • Add test coverage for efield capability
  • Add guard because Efield + EB is not supported

@baperry2 baperry2 requested a review from marchdf October 13, 2023 17:21
@marchdf
Copy link
Copy Markdown
Contributor

marchdf commented Oct 13, 2023

Well shoot maybe all that renaming was a bad idea?

@baperry2
Copy link
Copy Markdown
Collaborator Author

baperry2 commented Oct 16, 2023

Gonna merge this now and add the test coverage in a separate PR.

@baperry2 baperry2 merged commit 0210f10 into AMReX-Combustion:development Oct 16, 2023
@baperry2 baperry2 deleted the efield-fixes branch October 16, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marchdf marchdf marchdf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baperry2 @marchdf