paper acknowledgements and typos and fix some refs#278
Merged
esclapez merged 1 commit intoAMReX-Combustion:JOSS_paperfrom Oct 3, 2023
Merged
paper acknowledgements and typos and fix some refs#278esclapez merged 1 commit intoAMReX-Combustion:JOSS_paperfrom
esclapez merged 1 commit intoAMReX-Combustion:JOSS_paperfrom
Conversation
esclapez
added a commit
that referenced
this pull request
Oct 31, 2023
* First pass at a JOSS paper. * Including PeleLM contributions inheritance. Sorted alphabetically past MSD and I. * Minor changes to text. * Refs. update. * Typos in refs. * Fix AMReX-Hydro ref. * A few more typos. * Fix DOIs and add Candace independent affiliation. * Missing comma. * Another comma. * Update redistribution scheme reference. * Update B. Perry reference with CF paper. * Start adressing the reviewer comments. * Add efield paper to bib. * Update ref and add Marc HdF. * Update statement of need section. * paper acknowledgements and typos and fix some refs (#278) * Fix typos in joss paper (#280) Co-authored-by: Bruce Perry <[email protected]> * Update ORCIDs. * JOSS paper reference fixes (#298) Makes some minor fixes to references cited in the JOSS paper (capitalization, missing details) * Add CITATION.cff and update README.md * Fix Marc HdF split in .cff --------- Co-authored-by: Bruce Perry <[email protected]> Co-authored-by: Marc T. Henry de Frahan <[email protected]> Co-authored-by: Bruce Perry <[email protected]> Co-authored-by: Kyle Niemeyer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added acknoweldgements for NREL, NREL HPC, OLCF
Fix some typos
Add bib entry for PeleLM (to github, should this be to something else?)