Skip to content

Renaming LM -> LMeX#257

Merged
marchdf merged 1 commit intodevelopmentfrom
renaming
Sep 21, 2023
Merged

Renaming LM -> LMeX#257
marchdf merged 1 commit intodevelopmentfrom
renaming

Conversation

@marchdf
Copy link
Copy Markdown
Contributor

@marchdf marchdf commented Sep 19, 2023

No description provided.

@marchdf marchdf requested a review from jrood-nrel September 19, 2023 19:35
@baperry2
Copy link
Copy Markdown
Collaborator

baperry2 commented Sep 19, 2023

This will require several updates in the Docs:

https://amrex-combustion.github.io/PeleLMeX/manual/html/Implementation.html#overview-of-source-code
https://amrex-combustion.github.io/PeleLMeX/manual/html/Tutorials_HotBubble.html#problem-specifications

  • similarly in other tutorials
    and potentially other places...

@marchdf marchdf mentioned this pull request Sep 20, 2023
Merged
@marchdf
Copy link
Copy Markdown
Contributor Author

marchdf commented Sep 20, 2023

yikes good catch. Wondering if this is a good idea... I did a second pass and I think I caught a bunch more. There's still the input files though... they use controls like PeleLM.. But maybe that's ok? Or we break everyone's input file.

@marchdf marchdf requested a review from baperry2 September 20, 2023 14:50
@marchdf
Copy link
Copy Markdown
Contributor Author

marchdf commented Sep 20, 2023

Looks like I need AMReX-Combustion/PelePhysics#422 first because AMReX-Combustion/PelePhysics#417 broke some things.

baperry2
baperry2 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One consideration would be that we don't want to add friction to remaining LM users transitioning from LM to LMeX now that LM is no longer being supported. But I don't think this adds much to that burden. But I agree, let's not change the parmparse prefix.

@marchdf marchdf marked this pull request as ready for review September 21, 2023 14:19
@marchdf marchdf enabled auto-merge (squash) September 21, 2023 14:19
@marchdf marchdf merged commit 5487435 into development Sep 21, 2023
@marchdf marchdf deleted the renaming branch September 21, 2023 16:15
@baperry2 baperry2 mentioned this pull request Oct 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrood-nrel jrood-nrel jrood-nrel approved these changes

@baperry2 baperry2 baperry2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marchdf @baperry2 @jrood-nrel