Skip to content

Fix bug for isothermal EB on GPU#240

Merged
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom
baperry2:fix-gpu-isothermal-eb
Sep 8, 2023
Merged

Fix bug for isothermal EB on GPU#240
baperry2 merged 2 commits intoAMReX-Combustion:developmentfrom
baperry2:fix-gpu-isothermal-eb

Conversation

@baperry2
Copy link
Copy Markdown
Collaborator

@baperry2 baperry2 commented Sep 7, 2023

Closes #237

@taaresh1 can you verify that this solves your problem?

@baperry2 baperry2 requested a review from hsitaram September 7, 2023 23:05
@taaresh1
Copy link
Copy Markdown

taaresh1 commented Sep 7, 2023

@baperry2 This resolved the issue! Thanks a lot for the prompt response.

Copy link
Copy Markdown

@hsitaram hsitaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred to use const auto dx = Geom(lev).CellSizeArray(); instead of const Real* dx = Geom(lev).CellSize(); which is safe inside parallelfors

Thank you @baperry2 and @taaresh1 for fixing this issue

@baperry2 baperry2 merged commit a7364cb into AMReX-Combustion:development Sep 8, 2023
@baperry2 baperry2 deleted the fix-gpu-isothermal-eb branch September 8, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

peleLM.isothermal_EB = 1 causes CUDA error 700 - illegal memory access was encountered !!!

3 participants