Merged
Conversation
get help instructions.
now use PeleLMeX.
Collaborator
|
I merged in changes required to get tests to pass since something broke with using wget to get sundials. As a result, there's another environment variable (SUNDIALS_PATH) that can optionally be specified. I'll propagate that change into the readme, tutorials, etc. I also see a small typos, I'll try to get those as well before this gets merged. |
baperry2
approved these changes
Aug 29, 2023
Collaborator
baperry2
left a comment
baperry2
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this, Lucas. I think this covers pretty much all of the comments, although it may still be good to expand the beginning of the README with more of a statement of need / intended uses.
I fixed some typos and added a bit to the instructions for discussions/issues. Feel free to modify these changes if you'd like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @baperry2 @nickwimer !
This PR address most of the issues raised by the JOSS reviewers:
I'll get cracking on the change to the paper itself in the JOSS_paper branch.