Active Control max velocity default value fix#233
Merged
baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom Aug 22, 2023
Merged
Active Control max velocity default value fix#233baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom
Conversation
Collaborator
|
Thanks for doing this! Can you also modify the docs here to reflect the slightly updated behavior? Closes #232 |
baperry2
approved these changes
Aug 21, 2023
Collaborator
baperry2
left a comment
baperry2
left a comment
There was a problem hiding this comment.
Thanks again, this should be good assuming all the tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value for
m_ctrl_velMaxwas set to -1.0 inPeleLM.HThe updated velocity in
PeleLMFlowControler.cppis not limited by the maximum velocity parameter if the parameter value is less than zero.This result in the
active_control.velMaxinput file parameter being truly optional (see issue #232).Active control was able to converge without setting the
active_control.velMaxparameter: