Skip to content

Default value of active_control.velMax #232

@olivecha

Description

@olivecha

Upon adding active control to my simulation case, the inlet speed kept going to zero resulting in a flash-back.

I found out by looking at PeleLM.H that m_ctrl_velMax is set to zero by default, resulting in Vnew always being equal to zero:

225     Vnew = std::max(Vnew, 0.0);
227     Vnew = std::min(Vnew, m_ctrl_velMax);

I don't have an issue anymore with using active control as I know I can just supply a value to make my case work, but perhaps something should be changed either in the TripleFlame example:

active_control.velMax = 1.0               # Optional: limit inlet velocity

Or in the code by adding a condition for line 227 of PeleLMFlowControler.cpp (slow ?) or setting an arbitrary large default value in PeleLM.H (not good practice ?).

I would be appy to submit a pull request with the corresponding changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions