CI Updates - Include reference comparison#917
Merged
baperry2 merged 12 commits intoAMReX-Combustion:developmentfrom Apr 16, 2025
Merged
CI Updates - Include reference comparison#917baperry2 merged 12 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 12 commits intoAMReX-Combustion:developmentfrom
Conversation
Contributor
|
This is cool. Before I approve I'm going to request that the reference step is split into more steps though. Looking through test results is difficult otherwise. Also you can put |
jrood-nrel
reviewed
Apr 14, 2025
jrood-nrel
reviewed
Apr 14, 2025
jrood-nrel
reviewed
Apr 14, 2025
Contributor
|
After some thought, in the future, I bet we could easily cache the gold files from the |
jrood-nrel
reviewed
Apr 15, 2025
jrood-nrel
reviewed
Apr 15, 2025
jrood-nrel
reviewed
Apr 15, 2025
jrood-nrel
reviewed
Apr 15, 2025
jrood-nrel
reviewed
Apr 15, 2025
jrood-nrel
reviewed
Apr 15, 2025
jrood-nrel
approved these changes
Apr 16, 2025
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With nightly tests not running regularly, it's possible new PRs could be changing behavior without us realizing. The goal here is to add a comparison of simulation output to the current development branch as part of the CI.
This is done in a similar manner to the PeleLMeX unit tests: by checking out and building a reference copy of PeleLMeX and re-running reference cases for comparison as part of the CI. But here, we use CMake and the capability for comparison to gold files. This definitely isn't the most computationally efficient approach relative to storing gold files, but it is easy to implement and isn't horrible. It is only done for the macos-release test run.
To keep overall time for testing down, I split the 2D and 3D tests accross different runners so that they can go in parallel.
@jrood-nrel: I ignored ccache stuff in this implementation because I don't really understand how it works, but maybe that could help accelerate this?
The second to last commit in this PR has a change that causes the reference plotfile test to fail as a demonstration. That change is reverted in the final commit, showing the expected behavior where all comparisons pass.