Fix derive for state variables with ghost cells#707
Merged
baperry2 merged 4 commits intoAMReX-Combustion:developmentfrom Oct 23, 2023
Merged
Fix derive for state variables with ghost cells#707baperry2 merged 4 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 4 commits intoAMReX-Combustion:developmentfrom
Conversation
marchdf
reviewed
Oct 23, 2023
marchdf
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deriving a state variable with ghost cells, the derive function in AmrLevel does a FillPatch for the individual state variable. However, in PeleC, the
PCHypFillExtDirfunction can only operate on the full state, not individual variables. Therefore, instead of using the AmrLevel derive function in this case, we should manually FillPatch the whole state and then take the component that we need.Resolves #706 (the only time this problem comes up right now is when using the
adjacent_difference_greaterrefinement criterion with a state variable, which requires a ghost cell). Also cleans up the derive for LES variables, adds error checking toPCHypFillExtDirto ensure it is only called for the full state, and addsadjacent_difference_greaterto a test case.