Some improvements and testing for the EB covered state#704
Some improvements and testing for the EB covered state#704baperry2 merged 14 commits intoAMReX-Combustion:developmentfrom
Conversation
hsitaram
left a comment
There was a problem hiding this comment.
looks good! thank you, Bruce.
|
The end of timestep NaN check works at least on AMD and Nvidia GPUs (Frontier and Eagle). On GPU, the abort for invalid stencils only works in debug mode or with USE_ASSERTION=TRUE. Did not notice a change in performance. |
Tests/CMakeLists.txt
Outdated
| file(COPY ${TEST_FILES} DESTINATION "${CURRENT_TEST_BINARY_DIR}/") | ||
| # Set some default runtime options for all tests | ||
| set(RUNTIME_OPTIONS "amr.plot_file=plt amr.checkpoint_files_output=0 amr.plot_files_output=1 amrex.the_arena_is_managed=0") | ||
| set(RUNTIME_OPTIONS_AlL "amr.plot_file=plt amr.checkpoint_files_output=0 amr.plot_files_output=1 amrex.the_arena_is_managed=0") |
| set_tests_properties(${TEST_NAME} PROPERTIES WILL_FAIL TRUE) | ||
| endfunction(add_test_rf) | ||
|
|
||
| # Regression tests no FPE trapping ever |
There was a problem hiding this comment.
This test won't have these options amr.plot_file=plt amr.checkpoint_files_output=0 amr.plot_files_output=1 amrex.the_arena_is_managed=0, which I think we would want to enforce.
There was a problem hiding this comment.
Actually I'm confused. It just has the same options as the other tests?
There was a problem hiding this comment.
You could leave the RUNTIME_OPTIONS as is and just add amrex.signal_handling=0 to this test category.
This closes #703, with the goal of ensuring that covered cells never affect fluid cell values:
ebd.boundary_grad_stencil_type = 0)zero_in_bodyhas been deleted because it was not used anywhereTests/CMakeLists.txtbecause this test can't run with AMReX FPE trapping.