Reproducibility for EB covered state#702
Merged
jrood-nrel merged 7 commits intoAMReX-Combustion:developmentfrom Oct 11, 2023
Merged
Reproducibility for EB covered state#702jrood-nrel merged 7 commits intoAMReX-Combustion:developmentfrom
jrood-nrel merged 7 commits intoAMReX-Combustion:developmentfrom
Conversation
Contributor
|
Ah this is great. Thank you for looking at this. Long been on my todo list... I think there's a better way though. Let's chat. |
marchdf
approved these changes
Oct 9, 2023
marchdf
requested changes
Oct 10, 2023
marchdf
reviewed
Oct 10, 2023
marchdf
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state in cells covered by the EB is currently is set based on the value of the state in a somewhat arbitrarily selected fluid cell. Right now, the lexicographically first fluid cell in the first FAB containing fluid cells on the highest rank processor with a fluid cell is selected to populate the covered state.
The identity of this cell depends on the domain decomposition and therefore the covered state may change for a particular case when the number of processors or
amr.max_grid_sizeis changed. See below, for EB-C8 in 2D with 1 and 4 processors.With this PR, the lexicographically first fluid cell in the entire domain is chosen, so it is no longer depends on domain decomposition. As a result, both cases below will now be equivalent and match the
1 procversion. The code to do this is not very pretty, but I wasn't sure of a better way.This PR should have no effect on the actual solutions, but may lead to some diffs due to covered cells changing.
1 proc, current4 proc, current