Isothermal domain bc#684
Merged
baperry2 merged 13 commits intoAMReX-Combustion:developmentfrom Aug 30, 2023
Merged
Conversation
hsitaram
approved these changes
Aug 25, 2023
Contributor
hsitaram
left a comment
hsitaram
left a comment
There was a problem hiding this comment.
looking great! thank you Bruce
marchdf
reviewed
Aug 28, 2023
marchdf
reviewed
Aug 28, 2023
marchdf
reviewed
Aug 28, 2023
marchdf
reviewed
Aug 28, 2023
marchdf
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a robust isothermal wall capability. It addresses a need that has been brought up in various discussions/issues in the past (#263 #265 #502).
Isothermal walls are handled by separately computing the heat flux through walls after computing other diffusive fluxes (similar to how we handle EB isothermal wall fluxes). This avoids any issues with setting ghost cells that may affect the hydro calculations at the walls and also allows the values to be set directly on the face.
We see good agreement with and 2nd order convergence to the analytical solution for thermal diffusion from a wall into a semi-infinite medium
Tnorm = erf(x/sqrt(4*alpha*t))without hydro. Note the test includes diffusion from all walls in the domain but the data is taken early enough that the effects of various walls haven't started interacting with each other yet.Draft until documentation is added.