Merged
Conversation
marchdf
force-pushed
the
fix-mol-flux-factor
branch
from
35b2638 to
e35dd03
Compare
Contributor
|
Can you add in the test that will break if this is wrong to this PR? |
marchdf
force-pushed
the
fix-mol-flux-factor
branch
3 times, most recently
from
cb74548 to
9a99371
Compare
Contributor
Author
|
good idea, I tried to mimic what you did for masscons |
baperry2
approved these changes
Aug 17, 2023
marchdf
force-pushed
the
fix-mol-flux-factor
branch
3 times, most recently
from
81f07e4 to
8aeeae5
Compare
Contributor
|
Looks like EB-C9 and EB-C12 just need to have datlog set in the inputs file; ChannelFlow conserves mass but fails on energy because of the velocity forcing. |
marchdf
force-pushed
the
fix-mol-flux-factor
branch
from
8aeeae5 to
8722d55
Compare
Contributor
Author
|
Thanks for figuring that out! |
marchdf
force-pushed
the
fix-mol-flux-factor
branch
from
8722d55 to
74b48a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes mass conservation errors in MOL when there are multiple levels. Can someone tell me why this is not correct and why the previous way is correct?!