Skip to content

add BC checks in Godunov cmpflx#662

Merged
baperry2 merged 7 commits intoAMReX-Combustion:developmentfrom
baperry2:bc-update
Jul 26, 2023
Merged

add BC checks in Godunov cmpflx#662
baperry2 merged 7 commits intoAMReX-Combustion:developmentfrom
baperry2:bc-update

Conversation

@baperry2
Copy link
Copy Markdown
Contributor

@baperry2 baperry2 commented Jul 25, 2023

Bring in BC checks for walls and symmetry BCs from CAMR (AMReX-Fluids/CAMR#10).

To be added before merging this PR:

  • Simple test case demonstrating mass conservation

Future changes that will not be implemented in this PR:

  • This PR does not yet implement the changes for artificial viscosity at NoSlip boundaries, so in PeleC NoSlip boundaries may cause flow features to form in physically inviscid simulations due to the artificial viscosity.
  • Default user BCs to noslip walls with true reflect_odd for velocity
  • Modify treatment for user BCs in Godunov

@baperry2 baperry2 requested a review from marchdf July 25, 2023 20:51
@drummerdoc
Copy link
Copy Markdown
Contributor

true reflect_odd for viscosity? Not sure I get the meaning of that, or where that's done in the PR

@baperry2
Copy link
Copy Markdown
Contributor Author

Sorry that was a typo, it's been fixed to "true reflect odd for velocity". Right now, users have access to only the 1st interior cell when setting conditions in bcnormal, the plan is to give them both that and the reflected state (e.g., 3rd interior cell for the 3rd ghost cell) to enable better wall-type BCs to be set through bcnormal. But that's mostly unrelated to the contents of this PR.

This PR just makes sure that the appropriate wall BCs if applicable are applied when computing Godunov fluxes at the n+1/2 face states. This brings PeleC in line with CAMR.

@baperry2 baperry2 requested a review from jrood-nrel July 26, 2023 00:44
@baperry2
Copy link
Copy Markdown
Contributor Author

@jrood-nrel I've added a new test case to verify mass conservation, can you double check how that is implemented?

@baperry2 baperry2 marked this pull request as ready for review July 26, 2023 00:46
@baperry2 baperry2 merged commit 29a9030 into AMReX-Combustion:development Jul 26, 2023
@baperry2 baperry2 deleted the bc-update branch January 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants