Fix the if condition on the fillpatcher reset#651
Merged
marchdf merged 1 commit intodevelopmentfrom Jul 13, 2023
Merged
Conversation
jrood-nrel
approved these changes
Jul 12, 2023
The reset should not depend on the value of do_reflux
marchdf
force-pushed
the
fix-fillpatcher-cond
branch
from
4bdb262 to
b62fa1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fillpatcher reset should not depend on the value of do_reflux. With the current code, setting
pelec.do_reflux=0breaks withThis PR fixes that issue.