Skip to content

adding cavity flame input files#648

Closed
hsitaram wants to merge 10 commits intodevelopmentfrom
cavitycase
Closed

adding cavity flame input files#648
hsitaram wants to merge 10 commits intodevelopmentfrom
cavitycase

Conversation

@hsitaram
Copy link
Copy Markdown
Contributor

@hsitaram hsitaram commented Jul 9, 2023

  1. added case files from PeleC paper: Sitaraman et al. "Adaptive mesh based combustion simulations of direct fuel injection effects in a supersonic cavity flame-holder." Combustion and Flame 232 (2021): 111531.

  2. removed extrusion step in extruded triangles. The triangle planes are already extruded.

@hsitaram hsitaram requested a review from baperry2 July 9, 2023 18:59
Copy link
Copy Markdown
Contributor

@marchdf marchdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the PelePhysics submod update? Otherwise looks good

@hsitaram
Copy link
Copy Markdown
Contributor Author

fixed the pelephysics update. although it says "changed 0 files", not sure what that means.. I never get submodules right

@baperry2
Copy link
Copy Markdown
Contributor

Looking into some issues with the initialization, which appears to cause issues with excessive expansion near the leading edge of the cavity particularly on coarser grids

Copy link
Copy Markdown
Contributor

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some different initialization options that appear to make the initial transient more stable. With these options, everything is stable even on a 128x32x8 grid with no refinement.

@jrood-nrel jrood-nrel marked this pull request as draft July 11, 2023 17:55
@jrood-nrel jrood-nrel mentioned this pull request Jul 11, 2023
@jrood-nrel
Copy link
Copy Markdown
Contributor

I tried removing the submodule update on this branch, and I think this branch's history has a problem. I think we should play it careful with the submodule history so I made another PR for this #649 .

@jrood-nrel jrood-nrel closed this Jul 11, 2023
@jrood-nrel jrood-nrel deleted the cavitycase branch July 24, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants