Merged
Conversation
f88cc10 to
b5ab14c
Compare
marchdf
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will close issue: #642
Currently initializing from plt files is failing when the plt file is coarser than the simulation being initialized. That is because EB data structures are not initialized for coarsenings of the base grid in PeleC (in contrast to PeleLMeX). This causes the PltFileManager from PelePhysics to fail because it tries to create a new multifab at the coarse grid that relies on these data structures. This PR adds a new input option that modifies the EB initialization to allow for coarser levels for use when interpolating from a coarser plt file for initialization.
This PR also causes PeleC to abort if the refinement ratio is not 2 or 4 - the initialize_EB2 function requires this and prior behavior was just to segfault if other values were specified.