Update for compatibility with many-to-one spray #1007
Merged
baperry2 merged 16 commits intoAMReX-Combustion:developmentfrom Feb 18, 2026
Merged
Update for compatibility with many-to-one spray #1007baperry2 merged 16 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 16 commits intoAMReX-Combustion:developmentfrom
Conversation
Merged
9 tasks
Contributor
|
Tests are failing because of breaking changes in AMReX-Codes/amrex#4868, will push a fix soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates PeleC to support the new many-to-one spray capability by aligning source-term sizing and AMReX access patterns, plus small repo hygiene/documentation tweaks.
Changes:
- Adjust spray source-term count initialization to add particle-component contributions at runtime.
- Replace raw begin/end bounds access in diffusion source-term loop with explicit bounds helpers.
- Add semantic-versioning notes to README and ignore additional generated artifacts.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Submodules/PelePhysics | Bumps PelePhysics submodule to a commit that includes many-to-one spray support. |
| Source/Particle.cpp | Changes how num_spray_src is computed to incorporate per-particle-component source terms. |
| Source/Diffusion.cpp | Updates bounds access to use lbound/ubound helpers. |
| README.rst | Documents versioning approach and mapping from old YY.MM scheme. |
| .gitignore | Ignores additional output files (*.visit, Backtrace.*). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baperry2
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the changes necessary for the new many-to-one spray capability to work in PeleC (see PelePhysics #633.
To do:
A few comments:
SPRAY_FUEL_NUM <= NUM_SPECIESis still enforced. Eventually we should update the Spray-Evaporation test case similar to the SingleDropEvap in PeleLMeX.No diffs from
fcompareobserved when injection is enabled without breakupWith @baperry2's help, there are no longer diffs with
fcomparewhen breakup is enabled.