Specialize a Polymorphic ParticleContainer#428
Merged
ax3l merged 9 commits intoAMReX-Codes:developmentfrom Feb 14, 2026
Merged
Conversation
ax3l
force-pushed
the
topic-polymorphic-pc
branch
2 times, most recently
from
7fec74f to
3f4a8d2
Compare
ax3l
force-pushed
the
topic-polymorphic-pc
branch
from
a861396 to
3f8e140
Compare
ax3l
force-pushed
the
topic-polymorphic-pc
branch
from
3f8e140 to
602802b
Compare
ax3l
force-pushed
the
topic-polymorphic-pc
branch
from
602802b to
13fa823
Compare
atmyers
approved these changes
Dec 18, 2025
Member
|
AMReX-Codes/amrex#4859 adds a test for this at the C++ level. |
ax3l
force-pushed
the
topic-polymorphic-pc
branch
from
13fa823 to
e76f728
Compare
ax3l
force-pushed
the
topic-polymorphic-pc
branch
from
e76f728 to
e3794f0
Compare
Using the `amrex::PolymorphicArenaAllocator`
Skip all the other templated PC to save compile and link time.
Writable (with getter and setter).
ax3l
force-pushed
the
topic-polymorphic-pc
branch
from
e3794f0 to
e8564b0
Compare
ax3l
force-pushed
the
topic-polymorphic-pc
branch
from
8e63304 to
f15d882
Compare
Member
Author
|
Dang, the CUDA builder is exceeding some kind of resources: Unlikely disk space, because we clean a lot, but maybe RAM or so. We already run with only |
Simplify the TU, CI seems to exchaust RAM resources while compiling with NVCC.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+175
to
+177
| // work-around for https://github.com/pybind/pybind11/pull/4581 | ||
| //make_ArrayOfStructs<ParticleType, std::allocator> (m, "std"); | ||
| //make_ArrayOfStructs<ParticleType, amrex::ArenaAllocator> (m, "arena"); |
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+110
to
+112
| // work-around for https://github.com/pybind/pybind11/pull/4581 | ||
| //make_StructOfArrays<NReal, NInt, std::allocator, use64BitIdCpu>(m, "std"); | ||
| //make_StructOfArrays<NReal, NInt, amrex::ArenaAllocator, use64BitIdCpu>(m, "arena"); |
Check notice
Code scanning / CodeQL
Commented-out code Note
atmyers
pushed a commit
to BLAST-WarpX/warpx
that referenced
this pull request
Feb 20, 2026
- [x] replace all templates - [x] `setArena`, update `define()` calls, etc. - [x] remove unnecessary classes (e.g., `PinnedMemoryParticleContainer`): if `WarpXParticleContainer` had not purely virtual functions, this would be cleaner to implement (adding a `WarpXParticleContainer::Base` for now). - [x] test again on GPU at runtime - [x] rebase on AMReX-Codes/pyamrex#428 - [x] rebase on AMReX-Codes/amrex#4771 and simplify `make_alike` calls - [x] rebase on AMReX-Codes/amrex#4776 and AMReX-Codes/amrex#4948 and AMReX-Codes/amrex#4949
atmyers
pushed a commit
to atmyers/WarpX
that referenced
this pull request
Mar 23, 2026
- [x] replace all templates - [x] `setArena`, update `define()` calls, etc. - [x] remove unnecessary classes (e.g., `PinnedMemoryParticleContainer`): if `WarpXParticleContainer` had not purely virtual functions, this would be cleaner to implement (adding a `WarpXParticleContainer::Base` for now). - [x] test again on GPU at runtime - [x] rebase on AMReX-Codes/pyamrex#428 - [x] rebase on AMReX-Codes/amrex#4771 and simplify `make_alike` calls - [x] rebase on AMReX-Codes/amrex#4776 and AMReX-Codes/amrex#4948 and AMReX-Codes/amrex#4949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
amrex::PolymorphicArenaAllocator. Close #425To Do
amrex::PolymorphicArenaAllocatorLater On