Skip to content

Fix impicit MRI configuration calls#5093

Merged
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
gardner48:bugfix/implicit-mri
Feb 26, 2026
Merged

Fix impicit MRI configuration calls#5093
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
gardner48:bugfix/implicit-mri

Conversation

@gardner48
Copy link
Copy Markdown
Contributor

@gardner48 gardner48 commented Feb 26, 2026

Summary

Corrects Set function calls to configure the slow integrator with an implicit MRI method. This addresses the issues noted in #5044. The calls changed from ARKStep to MRIStep would work with SUNDIALS 7.1.0 or newer (when stepper specific Set functions were deprecated and replaced with common ARKode functions) but would fail with earlier versions of SUNDIALS.

Correct Set functions calls to configure an implicit fast integrator in an MRI method to use a fixed-point solver, modify the max number of iterations, or set the linear solver when using a Newton solver.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang merged commit a404d91 into AMReX-Codes:development Feb 26, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MRI slow integrator path uses ARKStep-specific API calls on MRIStep memory

2 participants