Fix impicit MRI configuration calls#5093
Merged
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom Feb 26, 2026
Merged
Fix impicit MRI configuration calls#5093WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
Conversation
9277271 to
664b97c
Compare
WeiqunZhang
reviewed
Feb 26, 2026
WeiqunZhang
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects
Setfunction calls to configure the slow integrator with an implicit MRI method. This addresses the issues noted in #5044. The calls changed fromARKSteptoMRIStepwould work with SUNDIALS 7.1.0 or newer (when stepper specificSetfunctions were deprecated and replaced with commonARKodefunctions) but would fail with earlier versions of SUNDIALS.Correct
Setfunctions calls to configure an implicit fast integrator in an MRI method to use a fixed-point solver, modify the max number of iterations, or set the linear solver when using a Newton solver.Additional background
Checklist
The proposed changes: