Skip to content

SUNDIALS Stale Flag#5092

Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
ajnonaka:sundials_stale_flag
Feb 26, 2026
Merged

SUNDIALS Stale Flag#5092
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
ajnonaka:sundials_stale_flag

Conversation

@ajnonaka
Copy link
Copy Markdown
Contributor

Calls to ARKStepSetMaxNumSteps do not assign their return value to flag, yet AMREX_ALWAYS_ASSERT(flag == 0) follows. The assert checks a stale value from a previous API call.

Fixes Issue #5045

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Calls to ARKStepSetMaxNumSteps do not assign their return value to flag, yet AMREX_ALWAYS_ASSERT(flag == 0) follows.
The assert checks a stale value from a previous API call.
@WeiqunZhang WeiqunZhang merged commit df7ccdc into AMReX-Codes:development Feb 26, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants