Merged
Conversation
Member
|
I'd suggest we be consistent about capitalization of hypre -- it looks like the LLNL folks themselves use both "hypre" and "HYPRE" so we can choose either but I'd suggest our comments be consistent with the capitalization so it's easier to search. Maybe "Hypre" in the function names and "hypre" or "HYPRE" in the comments? |
Member
Author
|
I have updated the comments in Src/Extern/HYPRE to use HYPRE consistently. As for Src/LinearSolvers/, to avoid conflicts, I will do it in a different PR. (I have a branch with a huge amount of changes, and I am splitting it into much smaller chunks.) |
Member
Author
|
I will also update sphinx doc in another PR. |
asalmgren
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.