prevent auto-converting const char * to bool in ParmParse::add#4969
Merged
WeiqunZhang merged 4 commits intoAMReX-Codes:developmentfrom Feb 24, 2026
Merged
prevent auto-converting const char * to bool in ParmParse::add#4969WeiqunZhang merged 4 commits intoAMReX-Codes:developmentfrom
WeiqunZhang merged 4 commits intoAMReX-Codes:developmentfrom
Conversation
WeiqunZhang
requested changes
Feb 23, 2026
Co-authored-by: Weiqun Zhang <[email protected]>
Contributor
Author
|
Thanks @WeiqunZhang - that make sense. Clearly I should have used |
WeiqunZhang
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParmParse::add("key", "value")will result in adding a boolean value (1) due to C++ converting pointer to bool. This is almost certainly not intended. Users must writeadd("key", std::string("value")which is cumbersome and easy to forget. Adding explicitconst char * -> std::stringoverload removes this pitfallAdditional background
Checklist
The proposed changes: