Merged
Conversation
2 tasks
ax3l
force-pushed
the
sensei-allocator-template
branch
from
4a3282b to
d841305
Compare
Add the `Allocator` template, so we can use this with polymorphic PCs (and generally any PC that does not use the default allocator).
ax3l
force-pushed
the
sensei-allocator-template
branch
from
d841305 to
ab6df6f
Compare
Error: ``` cannot add a default template argument to the definition of a member of a class template ```
Member
Author
|
/run-hpsf-gitlab-ci |
|
GitLab CI 1424337 finished with status: success. See details at https://gitlab.spack.io/amrex/amrex/-/pipelines/1424337. |
Member
Author
|
@WeiqunZhang @atmyers ready for review/merge :) |
atmyers
approved these changes
Feb 12, 2026
ax3l
added a commit
to BLAST-WarpX/warpx
that referenced
this pull request
Feb 13, 2026
Pull in the merged PRs - [x] AMReX-Codes/amrex#4948 - [x] AMReX-Codes/amrex#4949 for #6374
atmyers
pushed a commit
to BLAST-WarpX/warpx
that referenced
this pull request
Feb 20, 2026
- [x] replace all templates - [x] `setArena`, update `define()` calls, etc. - [x] remove unnecessary classes (e.g., `PinnedMemoryParticleContainer`): if `WarpXParticleContainer` had not purely virtual functions, this would be cleaner to implement (adding a `WarpXParticleContainer::Base` for now). - [x] test again on GPU at runtime - [x] rebase on AMReX-Codes/pyamrex#428 - [x] rebase on AMReX-Codes/amrex#4771 and simplify `make_alike` calls - [x] rebase on AMReX-Codes/amrex#4776 and AMReX-Codes/amrex#4948 and AMReX-Codes/amrex#4949
atmyers
pushed a commit
to atmyers/WarpX
that referenced
this pull request
Mar 23, 2026
Pull in the merged PRs - [x] AMReX-Codes/amrex#4948 - [x] AMReX-Codes/amrex#4949 for BLAST-WarpX#6374
atmyers
pushed a commit
to atmyers/WarpX
that referenced
this pull request
Mar 23, 2026
- [x] replace all templates - [x] `setArena`, update `define()` calls, etc. - [x] remove unnecessary classes (e.g., `PinnedMemoryParticleContainer`): if `WarpXParticleContainer` had not purely virtual functions, this would be cleaner to implement (adding a `WarpXParticleContainer::Base` for now). - [x] test again on GPU at runtime - [x] rebase on AMReX-Codes/pyamrex#428 - [x] rebase on AMReX-Codes/amrex#4771 and simplify `make_alike` calls - [x] rebase on AMReX-Codes/amrex#4776 and AMReX-Codes/amrex#4948 and AMReX-Codes/amrex#4949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the
Allocatortemplate, so we can use this with polymorphic PCs (and generally any PC that does not use the default allocator).Additional background
Same as #4776 #4948 but for SENSEI.
Checklist
The proposed changes: