Skip to content

ParticleContainerToBlueprint: Allocator (2)#4948

Merged
atmyers merged 1 commit intoAMReX-Codes:developmentfrom
ax3l:fix-conduit-blueprint-alloc
Feb 11, 2026
Merged

ParticleContainerToBlueprint: Allocator (2)#4948
atmyers merged 1 commit intoAMReX-Codes:developmentfrom
ax3l:fix-conduit-blueprint-alloc

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented Feb 11, 2026

Summary

Follow-up to #4776:
Forgot this, seen in CI of BLAST-WarpX/warpx#6374

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l requested review from WeiqunZhang and atmyers February 11, 2026 22:20
@ax3l ax3l added the bug label Feb 11, 2026
@ax3l ax3l mentioned this pull request Feb 11, 2026
7 tasks
@atmyers atmyers merged commit a28f3c1 into AMReX-Codes:development Feb 11, 2026
74 checks passed
@ax3l ax3l deleted the fix-conduit-blueprint-alloc branch February 12, 2026 02:10
ax3l added a commit to ax3l/warpx that referenced this pull request Feb 12, 2026
This was referenced Feb 12, 2026
atmyers pushed a commit that referenced this pull request Feb 12, 2026
## Summary

Add the `Allocator` template, so we can use this with polymorphic PCs
(and generally any PC that does not use the default allocator).

## Additional background

Same as  #4776 #4948 but for SENSEI.

## Checklist

The proposed changes:
- [ ] fix a bug or incorrect behavior in AMReX
- [x] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX
users
- [ ] include documentation in the code and/or rst files, if appropriate
ax3l added a commit to BLAST-WarpX/warpx that referenced this pull request Feb 13, 2026
atmyers pushed a commit to BLAST-WarpX/warpx that referenced this pull request Feb 20, 2026
- [x] replace all templates
- [x] `setArena`, update `define()` calls, etc.
- [x] remove unnecessary classes (e.g.,
`PinnedMemoryParticleContainer`): if `WarpXParticleContainer` had not
purely virtual functions, this would be cleaner to implement (adding a
`WarpXParticleContainer::Base` for now).
- [x] test again on GPU at runtime
- [x] rebase on AMReX-Codes/pyamrex#428
- [x] rebase on AMReX-Codes/amrex#4771 and
simplify `make_alike` calls
- [x] rebase on AMReX-Codes/amrex#4776 and
AMReX-Codes/amrex#4948 and
AMReX-Codes/amrex#4949
atmyers pushed a commit to atmyers/WarpX that referenced this pull request Mar 23, 2026
atmyers pushed a commit to atmyers/WarpX that referenced this pull request Mar 23, 2026
- [x] replace all templates
- [x] `setArena`, update `define()` calls, etc.
- [x] remove unnecessary classes (e.g.,
`PinnedMemoryParticleContainer`): if `WarpXParticleContainer` had not
purely virtual functions, this would be cleaner to implement (adding a
`WarpXParticleContainer::Base` for now).
- [x] test again on GPU at runtime
- [x] rebase on AMReX-Codes/pyamrex#428
- [x] rebase on AMReX-Codes/amrex#4771 and
simplify `make_alike` calls
- [x] rebase on AMReX-Codes/amrex#4776 and
AMReX-Codes/amrex#4948 and
AMReX-Codes/amrex#4949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants