FFTW CMake: Hint More Lib Paths (Windows)#4940
Merged
ax3l merged 1 commit intoAMReX-Codes:developmentfrom Feb 7, 2026
Merged
Conversation
Manually add the `lib/` path to `AMReX_FFTW_LIBRARY_DIRS`. Seems `FFTW3_LIBRARY_DIRS` is not very reliable. Refs.: - https://github.com/FFTW/fftw3/blob/fftw-3.3.10/CMakeLists.txt#L427C18-L427C38 - BLAST-ImpactX/impactx#1298
ax3l
changed the title
WeiqunZhang
approved these changes
Feb 6, 2026
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Feb 6, 2026
ax3l
changed the title
Member
Author
|
Test successful. |
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Feb 7, 2026
ax3l
added a commit
to cemitch99/impactx
that referenced
this pull request
Feb 9, 2026
* Release 26.02 The February release of ImpactX :) * CI: Win OpenMP FFTW * Tempoary: AMReX_FFTW_IGNORE_OMP=ON Reason: CMake Config OpenMP support missing. * [Patch] Try AMReX Fix AMReX-Codes/amrex#4940
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manually add the
lib/path toAMReX_FFTW_LIBRARY_DIRS. SeemsFFTW3_LIBRARY_DIRSis not very reliable and upstream FFTW does not register all libraries as exported targets in their CMake config file...Refs.:
Additional background
Test with ImpactX:
Checklist
The proposed changes: