Skip to content

Remove identity Lambdas in amrex::launch#4891

Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
AlexanderSinn:Remove_identity_Lambdas_in_amrex__launch
Jan 13, 2026
Merged

Remove identity Lambdas in amrex::launch#4891
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
AlexanderSinn:Remove_identity_Lambdas_in_amrex__launch

Conversation

@AlexanderSinn
Copy link
Copy Markdown
Member

@AlexanderSinn AlexanderSinn commented Jan 13, 2026 •
edited
Loading

Summary

I think these are unnecessary. Removing them shortens the name of the generated kernels a little bit.

Before:

void amrex::launch_global<(int)1024, void amrex::launch<(int)1024, void hpmg::<unnamed>::gsrb_shared<
(int)1, (bool)0,(bool)0, (bool)0>(const amrex::BoxND<(int)3> &, const amrex::Array4<double> &,
const amrex::Array4<const double> &, const amrex::Array4<const double> &, const amrex::Array4<double> &,
const amrex::Array4<const double> &, double, double)::
[lambda() (instance 1)]>(int, CUstream_st *, const T2 &)::[lambda() (instance 1)]>(T2)

After:

void amrex::launch_global<(int)1024, void hpmg::<unnamed>::gsrb_shared<
(int)1, (bool)0, (bool)0, (bool)0>(const amrex::BoxND<(int)3> &, const amrex::Array4<double> &,
const amrex::Array4<const double> &, const amrex::Array4<const double> &, const amrex::Array4<double> &,
const amrex::Array4<const double> &, double, double)::
[lambda() (instance 1)]>(T2)

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l added the cleaning label Jan 13, 2026
ax3l
ax3l approved these changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! :)

@WeiqunZhang WeiqunZhang merged commit 8c41360 into AMReX-Codes:development Jan 13, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ax3l ax3l ax3l approved these changes

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees

No one assigned

Labels

cleaning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexanderSinn @ax3l @WeiqunZhang