CI: Enable MPI in CUDA test on Windows#4869
Merged
WeiqunZhang merged 5 commits intoAMReX-Codes:developmentfrom Feb 4, 2026
Merged
CI: Enable MPI in CUDA test on Windows#4869WeiqunZhang merged 5 commits intoAMReX-Codes:developmentfrom
WeiqunZhang merged 5 commits intoAMReX-Codes:developmentfrom
Conversation
Member
Author
|
This is able to reproduce the first issue in #4867. |
Member
Author
|
The first issue in #4867 has been fixed. The CI test did not have the second issue likely because the fix in FBI.H also worked around it. Nevertheless, we can implement a more robust fix for BaseFab::atomicAdd. |
asalmgren
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.