Skip to content

Parser: Fix bugs in optimization#4866

Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
WeiqunZhang:parser_opt_fix
Dec 26, 2025
Merged

Parser: Fix bugs in optimization#4866
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
WeiqunZhang:parser_opt_fix

Conversation

@WeiqunZhang
Copy link
Copy Markdown
Member

Forgot to test function type for optimizations intended for pow function.

Close #4865

Forgot to test function type for optimizations intended for pow function.
Copy link
Copy Markdown
Contributor

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me.

@WeiqunZhang WeiqunZhang requested a review from atmyers December 24, 2025 17:46
@WeiqunZhang WeiqunZhang enabled auto-merge (squash) December 24, 2025 17:46
@WeiqunZhang WeiqunZhang merged commit 53dc0a4 into AMReX-Codes:development Dec 26, 2025
73 checks passed
@WeiqunZhang WeiqunZhang deleted the parser_opt_fix branch December 26, 2025 19:14
ankithadas pushed a commit to ankithadas/amrex that referenced this pull request Jan 7, 2026
Forgot to test function type for optimizations intended for pow
function.

Close AMReX-Codes#4865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parser optimizer rewrites f(x)/g(x) assuming g is pow, breaks max() and other F2 functions

3 participants