Use PolymorphicArenaAllocator in the SOAParticle test#4859
Merged
ax3l merged 1 commit intoAMReX-Codes:developmentfrom Jan 5, 2026
Merged
Use PolymorphicArenaAllocator in the SOAParticle test#4859ax3l merged 1 commit intoAMReX-Codes:developmentfrom
ax3l merged 1 commit intoAMReX-Codes:developmentfrom
Conversation
8 tasks
ax3l
reviewed
Jan 5, 2026
| using namespace amrex; | ||
|
|
||
| template <typename T_PC,template<class> class Allocator=DefaultAllocator> | ||
| template <typename T_PC,template<class> class Allocator=amrex::PolymorphicArenaAllocator> |
Member
There was a problem hiding this comment.
This looks like an unused template parameter to me...?
Suggested change
| template <typename T_PC,template<class> class Allocator=amrex::PolymorphicArenaAllocator> | |
| template <typename T_PC> |
ax3l
reviewed
Jan 5, 2026
| DistributionMapping dm(ba); | ||
|
|
||
| T_PC pc(geom, dm, ba); | ||
| pc.SetArena(The_Arena()); |
Member
There was a problem hiding this comment.
@atmyers what happens if someone changes the addParticles<...> template parameter to anything but amrex::PolymorphicArenaAllocator and tries to call SetArena()?
Just a test, but a bit funny.
ankithadas
pushed a commit
to ankithadas/amrex
that referenced
this pull request
Jan 7, 2026
This expands the coverage to include the C++ version of the functionality. The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the coverage to include the C++ version of the functionality.
The proposed changes: