Add SArena: The_Arena wrapper using Gpu::freeAsync#4835
Merged
WeiqunZhang merged 5 commits intoAMReX-Codes:developmentfrom Dec 9, 2025
Merged
Conversation
Member
|
/run-hpsf-gitlab-ci |
WeiqunZhang
reviewed
Dec 9, 2025
|
GitLab CI 1341585 finished with status: success. See details at https://gitlab.spack.io/amrex/amrex/-/pipelines/1341585. |
WeiqunZhang
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed here #4804 (comment), this PR adds a new memory arena that is a wrapper for The_Arena but calls freeAsync in its free function. The new arena, called SArena for stream-ordered arena, replaces the PArena in the implementation of The_Async_Arena.
Additional background
I have kept the profiling of the SArena for now. However, I'm not sure how useful it is since the CArena is already profiled.
Checklist
The proposed changes: