ParticleContainerToBlueprint: Allocator#4776
Merged
atmyers merged 1 commit intoAMReX-Codes:developmentfrom Nov 14, 2025
Merged
Conversation
Add the `Allocator` template, so we can use this with polymorphic PCs (and generally any PC that does not use the default allocator).
atmyers
approved these changes
Nov 14, 2025
ax3l
added a commit
to ax3l/amrex
that referenced
this pull request
Feb 11, 2026
5 tasks
atmyers
pushed a commit
that referenced
this pull request
Feb 11, 2026
## Summary Follow-up to #4776: Forgot this, seen in CI of BLAST-WarpX/warpx#6374 ## Additional background ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
atmyers
pushed a commit
that referenced
this pull request
Feb 12, 2026
## Summary Add the `Allocator` template, so we can use this with polymorphic PCs (and generally any PC that does not use the default allocator). ## Additional background Same as #4776 #4948 but for SENSEI. ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
atmyers
pushed a commit
to BLAST-WarpX/warpx
that referenced
this pull request
Feb 20, 2026
- [x] replace all templates - [x] `setArena`, update `define()` calls, etc. - [x] remove unnecessary classes (e.g., `PinnedMemoryParticleContainer`): if `WarpXParticleContainer` had not purely virtual functions, this would be cleaner to implement (adding a `WarpXParticleContainer::Base` for now). - [x] test again on GPU at runtime - [x] rebase on AMReX-Codes/pyamrex#428 - [x] rebase on AMReX-Codes/amrex#4771 and simplify `make_alike` calls - [x] rebase on AMReX-Codes/amrex#4776 and AMReX-Codes/amrex#4948 and AMReX-Codes/amrex#4949
atmyers
pushed a commit
to atmyers/WarpX
that referenced
this pull request
Mar 23, 2026
- [x] replace all templates - [x] `setArena`, update `define()` calls, etc. - [x] remove unnecessary classes (e.g., `PinnedMemoryParticleContainer`): if `WarpXParticleContainer` had not purely virtual functions, this would be cleaner to implement (adding a `WarpXParticleContainer::Base` for now). - [x] test again on GPU at runtime - [x] rebase on AMReX-Codes/pyamrex#428 - [x] rebase on AMReX-Codes/amrex#4771 and simplify `make_alike` calls - [x] rebase on AMReX-Codes/amrex#4776 and AMReX-Codes/amrex#4948 and AMReX-Codes/amrex#4949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the
Allocatortemplate, so we can use this with polymorphic PCs (and generally any PC that does not use the default allocator).Additional background
BLAST-WarpX/warpx#6374
Checklist
The proposed changes: