Skip to content

Fix cmake options table in documentation#4749

Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
atmyers:fix_cmake_docs_table
Nov 3, 2025
Merged

Fix cmake options table in documentation#4749
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
atmyers:fix_cmake_docs_table

Conversation

@atmyers
Copy link
Copy Markdown
Member

@atmyers atmyers commented Nov 3, 2025

This table wasn't being rendered properly in the docs.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from WeiqunZhang November 3, 2025 18:28
@atmyers atmyers assigned asalmgren and unassigned asalmgren Nov 3, 2025
@atmyers atmyers requested a review from asalmgren November 3, 2025 18:28
@WeiqunZhang WeiqunZhang merged commit bab255c into AMReX-Codes:development Nov 3, 2025
73 checks passed
@WeiqunZhang
Copy link
Copy Markdown
Member

We need to catch the error in the CI to prevent this from happening again.

@zingale
Copy link
Copy Markdown
Member

zingale commented Nov 3, 2025

we use:

 make SPHINXOPTS='-v -W --keep-going' NO_DOXYGEN=TRUE html

@atmyers
Copy link
Copy Markdown
Member Author

atmyers commented Nov 3, 2025

Let's try this: #4751

WeiqunZhang added a commit to WeiqunZhang/amrex that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants