PODVector: Add multiple growth strategies#4735
Closed
AlexanderSinn wants to merge 5 commits intoAMReX-Codes:developmentfrom
Closed
PODVector: Add multiple growth strategies#4735AlexanderSinn wants to merge 5 commits intoAMReX-Codes:developmentfrom
AlexanderSinn wants to merge 5 commits intoAMReX-Codes:developmentfrom
Conversation
5 tasks
WeiqunZhang
pushed a commit
that referenced
this pull request
Nov 3, 2025
While working on #4735 I noticed that in shrink_to_fit the newly allocated data pointer was not saved in the PODVector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an optional GrowthStrategy argument to some PODVector functions to switch the allocation strategy.
It is not yet clear to me which functions should be affected by the runtime controls and if the runtime controls should have priority over explicitly set strategies.
Discussion in #4715
Additional background
Checklist
The proposed changes: