align fcompare behavior with particle_compare when metadata differ#4724
Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom Oct 22, 2025
Merged
Conversation
zingale
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fcomparecrashes when boxes differ. This is confusing when interpreting the output, since it does not indicate an actual crash. In contrast,particle_compareprints an error message and returnsEXIT_FAILUREwhen metadata differ. This PR aligns fcompare with the behavior ofparticle_compare.Also fixes a copy-paste bug in the domain coverage check in fcompare.
Additional background
Checklist
The proposed changes: