Robustify file renaming#4721
Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom Oct 20, 2025
Merged
Conversation
In `amrex::UtilCreateCleanDirectory`, if a directory already exists, we preserve it by renaming it to a directory whose name includes a string generated by `amrex::UniqueString()`. However, this string is not guaranteed to be unique. The behavior of `std::rename` is implementation-defined, and it may fail if the destination already exists. This happens rarely, but it does happen. This PR addresses the issue by removing the existing conflicting directory before renaming. This makes the file renaming process more robust.
ax3l
reviewed
Oct 20, 2025
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
LGTM, thank you :)
Should TryFileOutput have a BL_PROFILE, too?
ax3l
approved these changes
Oct 20, 2025
Member
Author
|
I thought about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
amrex::UtilCreateCleanDirectory, if a directory already exists, we preserve it by renaming it to a directory whose name includes a string generated byamrex::UniqueString(). However, this string is not guaranteed to be unique. The behavior ofstd::renameis implementation-defined, and it may fail if the destination already exists. This happens rarely, but it does happen.This PR addresses the issue by removing the existing conflicting directory before renaming. This makes the file renaming process more robust.